Add tags with appVersion #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dong Ma <dong.ma@vexxhost.com>
mnaser
requested changes
May 20, 2025
Member
mnaser
left a comment
mnaser
left a comment
There was a problem hiding this comment.
I don't think this is going to give us what we need necessarily, because when using release-please, it will have different tags for all the different components, so in this case..
https://github.com/vexxhost/multipathd_exporter/tags
So it wouldn't be valid in this use case, which is why I think it would be better to do this in release time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In flake.nix, set tag = version, will get this tag